Reduce archivedb key lengths by 1 byte #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
danlaine,
darioush and
dboehm-avalabs
as code owners
StephenButtolph
added
storage
marun
reviewed
Sep 28, 2023
StephenButtolph
commented
Sep 28, 2023
| keyLen := len(key) | ||
| dbKeyMaxSize := binary.MaxVarintLen64 + keyLen | ||
| dbKey := make([]byte, dbKeyMaxSize) | ||
| offset := binary.PutUvarint(dbKey, uint64(keyLen)+1) |
There was a problem hiding this comment.
Note the +1 here making the prefix different than the user keys
darioush
approved these changes
Sep 28, 2023
marun
reviewed
Sep 28, 2023
marun
reviewed
Sep 28, 2023
dhrubabasu
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently we prefix all user database keys with a
0x00byte to provide a namespace for metadata. However, we can maintain the invariants of database keys without including that additional byte per key.How this works
User database keys are defined as:
keyLen | key | heightMetadata database keys as:
kenLen+1 | keyIn order for the user db keys to start with the same beginning as the metadata db keys, the user db keys must be one byte longer. As an example:
It's clear to see that a user db key (prefix!) can never itself be equal to or a prefix of a metadata db key.
How this was tested
Existing tests + added a new fuzz test. fwiw the fuzz test is pretty questionably useful... because of how few branches there are in the tested code.